Obtain Host Panic/Boot Failure Messages#2518
Conversation
Co-authored-by: Eliza Weisman <eliza@elizas.website>
| // this would only happen if packrat crashes. We could store some fake info here to | ||
| // continue preparing an ereport, but THAT is going to be a problem anyway because | ||
| // we send ereports to, you guessed it: packrat, which just crashed. | ||
| let response = self |
There was a problem hiding this comment.
There's probably something better we can do here as well, the only failure modes for a write_host_bootfail (and host panic) call are:
- That's illegal (not supported, OR client dies and revokes the lease)
- Packrat died
Neither of these are particulary good things (the former doesn't even matter here), and there might be a better way to express the idolatry IPC API to make this more clear in the generated code.
|
MGS message changes are tracked in oxidecomputer/management-gateway-service#495. |
|
Should be able to move this out of WIP tomorrow, progress update here: #2504 (comment). I'll address Eliza's comments before marking as ready for review. |
jamesmunns
changed the title
|
This is IMO ready to review, there are still a couple of |
| .unwrap_lite(); | ||
|
|
||
| // TODO: Do we want to give this to packrat too? | ||
| // TODO: Update `humility host boot-fail` to use packrat API! |
There was a problem hiding this comment.
This is still pending. I might need to open a humility PR that handles this elegantly.
2 participants
Not yet complete.
Closes #2504
Currently based on #2503